Skip to content

Ci/breaking change detection#358

Merged
sundargthb merged 1 commit intomainfrom
ci/breaking-change-detection
Mar 30, 2026
Merged

Ci/breaking change detection#358
sundargthb merged 1 commit intomainfrom
ci/breaking-change-detection

Conversation

@sundargthb
Copy link
Copy Markdown
Contributor

@sundargthb sundargthb commented Mar 23, 2026

Breaking Change Detection for PRs

Adds .github/workflows/breaking-change-check.yml to analyze every PR that
touches src/bedrock_agentcore/ for public API breaking changes, and posts a
warning comment on the PR if any are found.

What griffe detects

griffe is a static analysis library for Python APIs used by mkdocstrings,
Rye, and the broader Python packaging ecosystem. It understands:

  • Removed public modules, classes, functions, and attributes
  • Removed or changed __all__ exports
  • Changed function signatures: removed parameters, parameter kind changes
    (positional → keyword-only), default value changes
  • Class hierarchy changes (removed base classes)
  • Multi-line signatures, decorators, type annotations

Behavior

  • ✅ No breaking changes → posts a green check comment
  • ⚠️ Breaking changes found → posts a detailed list in markdown
  • 🛑 griffe errors (e.g. transient git issue) → posts an info comment, job stays green
  • Does not block merge — informational only

@sundargthb sundargthb requested a review from a team March 23, 2026 00:34
@sundargthb sundargthb force-pushed the ci/breaking-change-detection branch 5 times, most recently from 94c501f to e325308 Compare March 29, 2026 22:30
@sundargthb sundargthb enabled auto-merge (squash) March 30, 2026 04:03
@sundargthb sundargthb force-pushed the ci/breaking-change-detection branch from 721a236 to 6b21a27 Compare March 30, 2026 04:03
@sundargthb sundargthb merged commit 9341468 into main Mar 30, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants